[BinaryPlatforms]: Flesh out CPUID support #37722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
force-pushed
the
sf/flesh_out_cpuid
branch
from
ea29d05
to
2a0875b
Compare
giordano
reviewed
Sep 23, 2020
staticfloat
force-pushed
the
sf/flesh_out_cpuid
branch
2 times, most recently
from
e3e10d2
to
ab4620a
Compare
staticfloat
force-pushed
the
sf/flesh_out_cpuid
branch
2 times, most recently
from
ead64b8
to
8447834
Compare
This PR fleshes out (and slightly renames) some pieces of the CPUID machinery to better support BB's multi-march system. It declares at least one valid microarchitecture for all architectures, and splits the CPUID module out into its own source file for readability.
Get rid of `cpu_family()`, it's kind of confusingly named and unnecessary.
This should be a little more friendly to those just looking to inspect some of these objects
staticfloat
force-pushed
the
sf/flesh_out_cpuid
branch
from
8447834
to
6cc1a9f
Compare
staticfloat
force-pushed
the
sf/flesh_out_cpuid
branch
from
e8079d9
to
a788ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fleshes out (and slightly renames) some pieces of the CPUID
machinery to better support BB's multi-march system. It declares at
least one valid microarchitecture for all architectures, and splits the
CPUID module out into its own source file for readability.