Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BinaryPlatforms]: Remove overzealous verification #37705

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

staticfloat
Copy link
Sponsor Member

Some of these verifications are a little over-zealous. We don't
actually need cuda or march verification in here, since these will
be primarily externally-driven tags.

Some of these verifications are a little over-zealous.  We don't
actually need `cuda` or `march` verification in here, since these will
be primarily externally-driven tags.
@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 23, 2020

Why is it Marching here anyways? In the Makefile, there's a gcc flag name combined from -m arch that sources this name, but thus that name doesn't make sense outside of assembly a gcc command line.

@staticfloat
Copy link
Sponsor Member Author

staticfloat commented Sep 23, 2020

These march tags are what allow us to encode different microarchitectures into Artifacts.tomls, so we can use gcc -march=haswell -mtune=haswell to build an AVX2 version of a library, for instance. They were in here because as I was designing the new Platform type I had them in as part of some tests, but I'm moving this to be more externally driven until the march stuff is more stable.

@staticfloat staticfloat merged commit 57110b4 into master Sep 23, 2020
@staticfloat staticfloat deleted the sf/platform_verification branch September 23, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants