Enable Perf JITEvents by default #37682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any objections to this? |
|
Any reason not to just enable the GDB listener as soon as you use |
|
I think the issue is that these listeners will clutter your harddrive. Generally I think turning it on for |
vtjnash
approved these changes
Oct 1, 2020
vtjnash
reviewed
Nov 2, 2020
| USE_PERF_JITEVENTS ?= 0 | ||
| USE_PERF_JITEVENTS ?= 1 |
There was a problem hiding this comment.
We should have made this conditional on ifeq ($(OS),Linux), since LLVM now refuses to build on non-linux
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yggdrasil is already shipping with this integration, and so it would be nice to have this available on release builds.
I also added the option to enable GDB's JIT integration on normal builds.
For the perf support to work well one probably needs a very recent
perf.dotnet/coreclr#26897 (comment)