Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix an invalidation source in the TOML parser #37604

Merged
merged 1 commit into from
Sep 16, 2020
Merged

fix an invalidation source in the TOML parser #37604

merged 1 commit into from
Sep 16, 2020

Conversation

KristofferC
Copy link
Sponsor Member

Previously, we invalidated a lot from going down into typejoin with bad type information. This is completely unnecessary since, by virtue of the types we can actually parse, it will always evaluate to Any.

@KristofferC KristofferC added the compiler:latency Compiler latency label Sep 16, 2020
@KristofferC KristofferC merged commit 55bfc3f into master Sep 16, 2020
@KristofferC KristofferC deleted the kc/toml_invalid branch September 16, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timholy timholy timholy approved these changes

Assignees
No one assigned
Labels
compiler:latency Compiler latency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KristofferC @timholy