Fix coercion of floats to integer for %d printf specifier #37512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #37507. The issue here was the calling of `trunc` instead of `round` when coercing `AbstractFloat` arguments to `Integer`. Note this throws a scary warning and has undefined behavior in C, but it looks like legacy Printf code supported this, so we can try to do the right thing here. Previously, Printf called the grisu equivalent of `Ryu.writefixed(x, precision=0)` for float arguments, but as far as I can tell, calling `round(x)` should accomplish the same thing.
As noted in this comment, there is a subtle difference between the Grisu & Ryu algorithms in that the former rounds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37507. The issue here was the calling of
truncinstead ofroundwhen coercingAbstractFloatarguments toInteger. Note thisthrows a scary warning and has undefined behavior in C, but it looks
like legacy Printf code supported this, so we can try to do the right
thing here. Previously, Printf called the grisu equivalent of
Ryu.writefixed(x, precision=0)for float arguments, but as far as Ican tell, calling
round(x)should accomplish the same thing.