Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL: also catch ArgumentError in expanduser in tab completion #37434

Merged
merged 1 commit into from
Sep 10, 2020
Merged

REPL: also catch ArgumentError in expanduser in tab completion #37434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
REPL: also catch ArgumentError in expanduser in tab completion
  • Loading branch information
@KristofferC
KristofferC committed Sep 6, 2020
commit 93308801d26c8d2c5a6fbf7f406441383692a83c
4 changes: 2 additions & 2 deletions stdlib/REPL/src/REPLCompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,10 +278,10 @@ function complete_path(path::AbstractString, pos::Int; use_envpath=false, shell_
filesinpath = readdir(pathdir)
catch e
# Bash allows dirs in PATH that can't be read, so we should as well.
if isa(e, Base.IOError)
if isa(e, Base.IOError) || isa(e, Base.ArgumentError)
continue
else
# We only handle IOError here
# We only handle IOError and ArgumentError here
rethrow()
end
end
Expand Down