Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rouding for DateTime to Date #37286

Merged
merged 1 commit into from
Sep 11, 2020
Merged

add rouding for DateTime to Date #37286

merged 1 commit into from
Sep 11, 2020

Conversation

Moelf
Copy link
Sponsor Contributor

@Moelf Moelf commented Aug 30, 2020

fix #34782

@StefanKarpinski
Copy link
Sponsor Member

@omus or @quinnj, either of you willing to review this?

@fredrikekre fredrikekre added the domain:dates Dates, times, and the Dates stdlib module label Sep 11, 2020
quinnj
quinnj approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quinnj quinnj merged commit 60c36f3 into JuliaLang:master Sep 11, 2020
@simeonschaub
Copy link
Member

It seems like this broke tests on master.

@fredrikekre
Copy link
Member

Indeed

Test Failed at /buildworker/worker/tester_linux64/build/share/julia/stdlib/v1.6/Dates/test/rounding.jl:198
  Expression: round(Date, now_, p) == round(Date, now_, p, RoundUp)
   Evaluated: Dates.Date("2020-09-01") == Dates.Date("2020-10-01")

@quinnj
Copy link
Member

quinnj commented Sep 11, 2020

Ah, the answer has now changed since rounding up gives Oct 1 instead of Sept 1.

@quinnj
Copy link
Member

quinnj commented Sep 11, 2020

Fix is up: #37528

@Moelf Moelf mentioned this pull request Oct 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

@omus omus Awaiting requested review from omus

Assignees
No one assigned
Labels
domain:dates Dates, times, and the Dates stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Floor / Ceil methods for Number and Period Inconsistency
5 participants
@Moelf @StefanKarpinski @simeonschaub @fredrikekre @quinnj