Remove unnecessary volatile on memcpy #37221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a local bitcast of different size through memory and doesn't need to be volatile. This was introduced due to a typo in 8e4327c when the argument order changed and the old tbaa parameter was passed in as isvolatile.
oscardssmith
pushed a commit
to oscardssmith/julia
that referenced
this pull request
Aug 28, 2020
This is a local bitcast of different size through memory and doesn't need to be volatile. This was introduced due to a typo in 8e4327c when the argument order changed and the old tbaa parameter was passed in as isvolatile.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
This is a local bitcast of different size through memory and doesn't need to be volatile. This was introduced due to a typo in 8e4327c when the argument order changed and the old tbaa parameter was passed in as isvolatile.
oscardssmith
added a commit
to oscardssmith/julia
that referenced
this pull request
Sep 14, 2020
author Oscar Smith <[email protected]> 1595400985 -0400 committer Oscar Smith <[email protected]> 1600122971 -0500 parent a0a68a5 author Oscar Smith <[email protected]> 1595400985 -0400 committer Oscar Smith <[email protected]> 1600122964 -0500 parent a0a68a5 author Oscar Smith <[email protected]> 1595400985 -0400 committer Oscar Smith <[email protected]> 1600122905 -0500 A faster version of exp for Float64 This is based on the Glibc algorithm which @chriselrod (Elrond on discourse) described the algorithm of for me. It appears to be about 2x faster than the current algorithm, and equally accurate over the range for which I have tried it. It also theoretically should be easier to vectorize as branches are only used for checking for over/underflow. Update base/special/exp.jl Co-authored-by: Jeff Bezanson <[email protected]> Better subnormal numbers, constant usage, and more accurate Break r into a hi and lo part to get extra accuracy. Fix previous comit. Error matches gexp Switch to minimax polynomial from taylor polynomial. equally fast version with a smaller table. Uses a quartic which allows a smaller table. Performance is equal to slightly better, and accuracy is similar. fully working? fix markdown rendering (JuliaLang#37235) add another deprecated internal function for backwards compat (JuliaLang#36794) Remove unnecessary volatile on memcpy (JuliaLang#37221) This is a local bitcast of different size through memory and doesn't need to be volatile. This was introduced due to a typo in 8e4327c when the argument order changed and the old tbaa parameter was passed in as isvolatile. aysnchronous typos (JuliaLang#37264) use printf/exit instead of `jl_error` for "too many threads" (JuliaLang#37223) This is too early for `jl_error` to work. fix expm1 for Float32 (calling wrong libm function) actually fix expm1 re-add exp10 docs slightly extend upper range for Float32 arguments re-add exp doctest, remove redundant exp10 doctest maybe now placing it after use round instead of magic re-add magic with better explanation remove the typo Fix all numbers taking the slow path with range checking. Oops Fix 32 bit build. Use `:ℯ` instead of `float64 ℯ` no functional change but less hacky Update base/special/exp.jl Co-authored-by: jmert <[email protected]> Update base/special/exp.jl Co-authored-by: jmert <[email protected]> Update base/special/exp.jl Co-authored-by: jmert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a local bitcast of different size through memory and doesn't need to be volatile.
This was introduced due to a typo in 8e4327c when the
argument order changed and the old tbaa parameter was passed in as isvolatile.