add some needed local declarations to macros
#37219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
reviewed
Aug 26, 2020
base/logging.jl
Outdated
| file = $(log_data._file) | ||
| line = $(log_data._line) | ||
| local file = $(log_data._file) | ||
| local line = $(log_data._line) |
There was a problem hiding this comment.
guess we can wrap the entire block into let instead of adding bunch of locals ? I hope it would look simpler
to avoid leaking globals
JeffBezanson
force-pushed
the
jb/macrolocals
branch
from
4c9ce4e
to
e8b6b7b
Compare
aviatesk
approved these changes
Aug 27, 2020
Comment on lines
+646
to
+647
| push!(lowering, :(local $sym = $(GlobalRef(Base, :cconvert))($etype, $earg))) | ||
| push!(lowering, :(local $sym2 = $(GlobalRef(Base, :unsafe_convert))($etype, $sym))) |
There was a problem hiding this comment.
another nit pick, why can't we directly interpolate functions ?
Suggested change
| push!(lowering, :(local $sym = $(GlobalRef(Base, :cconvert))($etype, $earg))) | |
| push!(lowering, :(local $sym2 = $(GlobalRef(Base, :unsafe_convert))($etype, $sym))) | |
| push!(lowering, :(local $sym = $(Base.cconvert)($etype, $earg))) | |
| push!(lowering, :(local $sym2 = $(Base.unsafe_convert)($etype, $sym))) |
There was a problem hiding this comment.
While we allow that, it's a bit of a misfeature. It's better for code to describe where an object comes from, or how it is computed, than to contain the object itself. One way to think of it is that code is a textual description, so it should only contain text.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
to avoid leaking globals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid leaking globals