Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv upgrade to v2-1.39.0 #37217

Merged
merged 1 commit into from
Sep 25, 2020
Merged

libuv upgrade to v2-1.39.0 #37217

merged 1 commit into from
Sep 25, 2020

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Aug 26, 2020

Needs libuv/libuv#2838 still, but I don't have a clean version of that change to apply. @staticfloat can you make a PR to libuv that I can use as the reference patch?

* 87d3a78a - Remove incorrect constant in chmod (#12) (5 weeks ago) <Elliot Saba>
*   2d109120 - Merge pull request #10 from JuliaLang/sf/inheritance (4 months ago) <Elliot Saba>
|\  
| * 2b839f1c - Alter permissions given in chmod (4 months ago) <Elliot Saba>
|/  
*   183e5558 - Merge pull request #9 from JuliaLang/sf/readonly_chmod (4 months ago) <Elliot Saba>
|\  
| * 3e3e203c - Propagate permissions, and fix readonly permission ordering (4 months ago) <Elliot Saba>
* | b5bf0b87 - Merge pull request #8 from JuliaLang/sf/readonly_chmod (4 months ago) <Elliot Saba>
|\| 
| * 62808ca2 - win,fs: Continue to set `FILE_ATTRIBUTE_READONLY` (4 months ago) <Elliot Saba>
|/  
*   659812b7 - Merge pull request #6 from JuliaLang/sf/win_acl (4 months ago) <Elliot Saba>
|\  
| * 173a9acb - Fix c89 pedantic warnings (4 months ago) <Elliot Saba>
| * 3ce845cd - win,fs: Add more complete `fs__chmod()` implementation (4 months ago) <Elliot Saba>
| * ce539ac6 - win,fs: Upgrade `fs__access()` to respond to `X_OK`. (8 months ago) <Elliot Saba>

@musm
Copy link
Contributor

musm commented Aug 26, 2020

Awesome, thanks for doing this.

@musm
Copy link
Contributor

musm commented Sep 23, 2020

https://github.com/JuliaLang/julia/blob/master/test/file.jl#L544

-    for i = 0:8
+    for i = 0:9
         local tmp = joinpath(PATH_PREFIX, "x"^MAX_PATH * "123456789"[1:i])
         @test withenv(var => tmp) do
             tempdir()
         end == (tmp)
     end
-    for i = 9
-        local tmp = joinpath(PATH_PREFIX, "x"^MAX_PATH * "123456789"[1:i])
-        if Sys.iswindows()
-            # libuv bug
-            @test_broken withenv(var => tmp) do
-                tempdir()
-            end == tmp
-        else
-            @test withenv(var => tmp) do
-                tempdir()
-            end == tmp
-        end
-    end

@vtjnash vtjnash marked this pull request as ready for review September 24, 2020 14:53
@vtjnash vtjnash merged commit 04a5be7 into master Sep 25, 2020
@vtjnash vtjnash deleted the jn/libuv2-1.39.0 branch September 25, 2020 12:36
@JeffBezanson
Copy link
Sponsor Member

generate_precompile seems to hang for me after this.

@staticfloat
Copy link
Sponsor Member

On which platform? Can you switch this debug out to stdout and see where it's hanging?

@JeffBezanson
Copy link
Sponsor Member

Ah, looks like a segfault during addprocs:

julia> addprocs(2)

signal (11): Segmentation fault
in expression starting at REPL[17]:1
macro expansion at ./libuv.jl:38 [inlined]
uv_connectcb at /home/jeff/src/julia/usr/share/julia/stdlib/v1.6/Sockets/src/Sockets.jl:477
unknown function (ip: 0x7f3401817655)
uv__stream_connect at /workspace/srcdir/libuv/src/unix/stream.c:1381
uv__stream_io at /workspace/srcdir/libuv/src/unix/stream.c:1298
uv__io_poll at /workspace/srcdir/libuv/src/unix/linux-core.c:447
uv_run at /workspace/srcdir/libuv/src/unix/core.c:379
jl_process_events at /home/jeff/src/julia/src/jl_uv.c:214
process_events at ./libuv.jl:104 [inlined]
wait at ./task.jl:747 [inlined]
wait at ./condition.jl:106
_trywait at ./asyncevent.jl:111
wait at ./asyncevent.jl:129 [inlined]
sleep at ./asyncevent.jl:214
read_worker_host_port at /home/jeff/src/julia/usr/share/julia/stdlib/v1.6/Distributed/src/cluster.jl:318

The handle data looks corrupt; data is 0x56415741e5894855.
Linux x86_64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants