Let LinearIndices(::Broadcasted) return LinearIndices
#37186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
reviewed
Aug 25, 2020
martinholters
force-pushed
the
mh/linearindices-broadcasted
branch
from
86fa46b
to
0e9b5b0
Compare
mbauman
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/JuliaLang/julia/pull/31020/files#r475669025. Not that it has caused me any trouble, but a constructor that returns an instance of another type than requested does have the potential for nasty surprises. And here, I don't think there is any advantage in not returning a
LinearIndices... but I don't know my ways around the broadcast code, so I might be wrong.While at it, this generalizes the definition to arbitraryBroadcasted.