[NFC] C code clearn up #37185
Merged
[NFC] C code clearn up #37185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused functions that are not obviously kept for debugging * Make functions/variables not used in other files static * Move non-static declarations of function and variables to headers * Remove non-exported API and it's users from `julia.h` (moved to `julia_internal.h`) This removes `jl_vararg_kind_t` from public header. It's technically breaking. But since no one could actually use its value due to the function that produces this being not callable, this shouldn't break any actual/useful code.
yuyichao
force-pushed
the
yyc/c-cleanup
branch
from
fab9b5a
to
bb74fe9
Compare
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
* Remove unused functions that are not obviously kept for debugging * Make functions/variables not used in other files static * Move non-static declarations of function and variables to headers * Remove non-exported API and it's users from `julia.h` (moved to `julia_internal.h`) This removes `jl_vararg_kind_t` from public header. It's technically breaking. But since no one could actually use its value due to the function that produces this being not callable, this shouldn't break any actual/useful code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused functions that are not obviously kept for debugging
Make functions/variables not used in other files static
Move non-static declarations of function and variables to headers
Remove non-exported API and it's users from
julia.h(moved tojulia_internal.h)This removes
jl_vararg_kind_tfrom public header. It's technically breaking.But since no one could actually use its value due to the function that produces this being not callable,
this shouldn't break any actual/useful code.
For reviewing, the main things to check are,
julia.htojulia_internal.hJL_DLLEXPORTdefinition.JL_DLLEXPORTdeclaration and static/inline definition fromjulia.h