Support LLVM 10 in GC checker #37153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did a run with LLVM 10 and the GCChecker https://build.julialang.org/#/builders/65/builds/2239/steps/4/logs/stdio |
|
The only failure I got locally is due to LLVM not able to infer that diff --git a/src/llvm-alloc-opt.cpp b/src/llvm-alloc-opt.cpp
index 6f2a69dea9..eb1abe932d 100644
--- a/src/llvm-alloc-opt.cpp
+++ b/src/llvm-alloc-opt.cpp
@@ -1318,6 +1318,7 @@ void Optimizer::splitOnStack(CallInst *orig_inst)
}
else if (auto call = dyn_cast<CallInst>(user)) {
auto callee = call->getCalledOperand();
+ assert(callee);
if (auto intrinsic = dyn_cast<IntrinsicInst>(call)) {
if (Intrinsic::ID id = intrinsic->getIntrinsicID()) {
if (id == Intrinsic::memset) { |
|
Hm, I am getting the same failure locally. @Keno |
|
Running with the core checker excluded I also get the following failure: |
|
It thinks the In |
|
Actually I can reproduce it too if core check is disabled. It seems that the return statement was diff --git a/src/clangsa/GCChecker.cpp b/src/clangsa/GCChecker.cpp
index 4e7d708a67..8bba1d37d2 100644
--- a/src/clangsa/GCChecker.cpp
+++ b/src/clangsa/GCChecker.cpp
@@ -727,7 +727,7 @@ void GCChecker::checkEndFunction(const clang::ReturnStmt *RS,
C.addTransition(State);
if (!C.inTopFrame())
return;
- if (C.getState()->get<GCDepth>() > 0)
+ if (RS && C.getState()->get<GCDepth>() > 0)
report_error(C, "Non-popped GC frame present at end of function");
}seems to fix it and also seems correct in general (there are other cases where a NULL is passed here and this just seem to be the only case where it actually trigger an error...) |
Ref llvm/llvm-project@2f169e7 Ref llvm/llvm-project@6b85f8e Also handle noreturn function call in GC frame counting, and remove some old code for LLVM <= 7
|
This is not user facing code and I believe there shouldn't be regression on LLVM 9 at least so I'll merge soon to make it easier for me to test a few other changes. I also removed some old code for LLVM <= 7 support. It also seems that the core analyzer might be responsible for handling no-return function in general. Even with the NULL return statement case factored out there are other related issues from the caller of the function. Still not sure why the core analyzer complains what it does. I have a non-asserting and release build of LLVM maybe that makes a difference? |
|
I am just running the Yggdrasil build, so that is also non-asserting and release. It's weird that we are also seeing it on CI otherwise I might blame a header difference. |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
Ref llvm/llvm-project@2f169e7 Ref llvm/llvm-project@6b85f8e Also handle noreturn function call in GC frame counting, and remove some old code for LLVM <= 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref llvm/llvm-project@2f169e7
Ref llvm/llvm-project@6b85f8e
Also handle noreturn function call in GC frame counting,
and remove some old code for LLVM <= 7