REPL: print to stdout instead of TTYTerminal to avoid over-specialization #37127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we be more thorough and do this inside |
|
I thought about that too and convinced myself it didn't work. But it totally does so changed to that... |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
…tion (JuliaLang#37127) * REPL: print to stdout instead of TTYTerminal to avoid over specialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37020. Implements the suggestion in #37094 (comment).
Now the
IOthat the REPL passes down to the display system has the same type as the one used in non-interactive use. The precompilation statements collected in the REPL are therefore also valid for the non-interactive use-case.