Rewrite shell_parse #37093
Merged
Rewrite shell_parse #37093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made changes to `shell_parse` perhaps three times already. This PR hopefully finishes the job by abandoning the original closure-based design altogether and using a style that inference likes better.
KristofferC
approved these changes
Aug 26, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
I've made changes to `shell_parse` perhaps three times already. This PR hopefully finishes the job by abandoning the original closure-based design altogether and using a style that inference likes better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made changes to
shell_parseperhaps three times already. This PR hopefully finishes the job by abandoning the originalclosure-based design altogether and using a style that inference likes better.