Ensure that BitArrays are inferrable for arbitrary Integer
#37082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
599efe0
to
46cba9b
Compare
BitArray operations are frequently performed with partial inference
information (particularly from Pkg but others as well).
Currently the internal operations are a source of invalidation for
common arithmetic and bitwise operators. There seems to be no need
to live with this, as all the inference problems are fixed by
converting `Integer`s to `Int`s. This is done elsewhere already in
BitArray code, so it only seems to be continuing a process that is
already underway.
Because of the multiplicity of methods `BitArray{N}(a::Any)` is not
fully inferrable but there are at least limited victories,
and the real benefits are in the elimination of instabilities
in the internal operations.
46cba9b
to
83877fc
Compare
83877fc
to
b9a8b30
Compare
KristofferC
approved these changes
Aug 26, 2020
| @@ -933,6 +947,7 @@ function _deleteat!(B::BitVector, i::Integer) | |||
| end | |||
|
|
|||
| function deleteat!(B::BitVector, i::Integer) | |||
| i = Int(i) | |||
There was a problem hiding this comment.
Could do the "split out the Int conversion part"-dance here as well.
There was a problem hiding this comment.
My feeling is the bit of bounds-checking isn't worth worrying about.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
…ng#37082) BitArray operations are frequently performed with partial inference information (particularly from Pkg but others as well). Currently the internal operations are a source of invalidation for common arithmetic and bitwise operators. There seems to be no need to live with this, as all the inference problems are fixed by converting `Integer`s to `Int`s. This is done elsewhere already in BitArray code, so it only seems to be continuing a process that is already underway. Because of the multiplicity of methods `BitArray{N}(a::Any)` is not fully inferrable but there are at least limited victories, and the real benefits are in the elimination of instabilities in the internal operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BitArray operations are frequently performed with partial inference information (particularly from Pkg but others as well). Currently the internal operations are a source of invalidation for common arithmetic and bitwise operators. There seems to be no need to live with this, as all the inference problems are fixed by converting
Integers toInts. This is done elsewhere already in BitArray code, so it only seems to be continuing a process that is already underway.Because of the multiplicity of methods
BitArray{N}(a::Any)is not fully inferrable but there are at least limited victories, and the real benefits are in the elimination of instabilities in the internal operations.