win32: fix in_stackwalk mutex #37002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make this previously non-atomic mutex threadsafe. Fixes #35117
|
This is supposed to lock out doing a backtrace while adding new symbols? What happens when the profiler fires while we're in that code? Shouldn't there be a |
|
I intended to have the profiler get the lock before stopping any threads. I considered alternatively using trylock, but hoped it shouldn't add too much noise (beyond the problems already seen with profiling thread scaling in the presence of locks #9224). I think I may have forgotten to finish with doing that part of the PR however (cf. your past work in #34454 and open issue #13294) |
|
Hmm, I see, I guess that works on win/mac since the profiler starts on a separate thread. This LGTM then. |
Keno
approved these changes
Aug 11, 2020
JeffBezanson
added
kind:bugfix
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
This should make this previously non-atomic mutex threadsafe. Fixes JuliaLang#35117
Sacha0
pushed a commit
that referenced
this pull request
Oct 23, 2020
This should make this previously non-atomic mutex threadsafe. Fixes #35117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make this previously non-atomic mutex threadsafe.
Fixes #35117