Some cleanup and comment for addrspace tracking in codegen #36920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Aug 4, 2020
vtjnash
approved these changes
Aug 4, 2020
* Document returned LLVM type for a few functions * Require and assert `Vboxed` to be of type `T_prjlvalue` * Remove unused branch/specialization of `maybe_decay_tracked` * Add function to cast known-untracked value.
yuyichao
force-pushed
the
yyc/codegen/track
branch
from
0cb07b8
to
964fc9f
Compare
Keno
approved these changes
Aug 4, 2020
|
Seems like a few PRs with 1.5 backport label depends on this. |
|
Any use of v_rnull can just be replaced with how it is defined here, or in case it was changed from a equivalent value just leave it unchanged. |
|
Think I got them: https://github.com/JuliaLang/julia/compare/b24f5946954399bc..dbf74365f0d. Feel free to look it over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits should be purely spelling change/clean up.
The last commit deals exclusively with
maybe_decay_tracked.Unify and document the returned LLVM type for a few common functions.
Require
boxedand the.Vboxedfields to beT_prjlvalue.AFAICT many places are assuming this already. So what I've changed is to document this and add a few assertions to make sure this invariance hold when it's unclear from just local information.
Remove the "maybe"-ness of the cast in most places.
Turns out that almost all the usecases have known input types.
Cleanup
maybe_decay_trackeditself.AFAICT, there's no use of the function that uses the
T_pprjlvaluebranch. It should also be nice to reduce reliance on the eltype of pointers.