Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #36783, more specialization on called Type arguments #36795

Merged
merged 2 commits into from
Jul 28, 2020
Merged

fix #36783, more specialization on called Type arguments #36795

merged 2 commits into from
Jul 28, 2020

Conversation

JeffBezanson
Copy link
Sponsor Member

fix #36783

@JeffBezanson JeffBezanson added the performance Must go faster label Jul 24, 2020
vtjnash
vtjnash approved these changes Jul 24, 2020
View reviewed changes
src/gf.c
@@ -874,14 +878,15 @@ JL_DLLEXPORT int jl_isa_compileable_sig(
}
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vague think the previous conditional (jl_is_kind(elt)) should return 0 if iscalled, but there's a TODO there that it's possibly missing other cases already

@JeffBezanson JeffBezanson merged commit e059758 into master Jul 28, 2020
@JeffBezanson JeffBezanson deleted the jb/fix36783 branch July 28, 2020 20:19
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
@JeffBezanson @simeonschaub
fix JuliaLang#36783, more specialization on called Type arguments (Ju…
9a8bb1f 
…liaLang#36795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inference failure for Float64 constructor?
2 participants
@JeffBezanson @vtjnash