Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pbpaste error on MacOS buildbots #36763

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix pbpaste error on MacOS buildbots #36763

merged 1 commit into from
Jul 22, 2020

Conversation

staticfloat
Copy link
Member

We had a typo here for many a year; apparently the older buildbots did
not need reattach-to-user-namespace quite as desperately as we thought
they did.

We had a typo here for many a year; apparently the older buildbots did
not need `reattach-to-user-namespace` quite as desperately as we thought
they did.
@Keno
Copy link
Member

Keno commented Jul 22, 2020

Can we just call reattach on the entire buildbot process? It seems a little odd to do that here (of course we should still merge this as soon as it passes, so we can fix CI).

@staticfloat
Copy link
Member Author

We can, but note that the primary use of this is for people who run inside of tmux on a normal OSX system, not for CI. This was fixed in tmuxs 2.6+, but that's still new enough that it's nice to automatically fix it for users that have reattach-to-user-namespace installed.

@JeffBezanson JeffBezanson added backport 1.5 bugfix This change fixes an existing bug ci Continuous integration labels Jul 22, 2020
@staticfloat staticfloat merged commit 80cdfa1 into master Jul 22, 2020
@staticfloat staticfloat deleted the sf/which_hunt branch July 22, 2020 18:16
JeffBezanson pushed a commit that referenced this pull request Jul 23, 2020
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants