Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sorting API refactor using keywords #3665

Merged
merged 7 commits into from
Jul 11, 2013
Merged

sorting API refactor using keywords #3665

merged 7 commits into from
Jul 11, 2013

Commits on Jul 11, 2013

  1. sorting: make order and alg keyword arguments. 

    The idea here is that the ordering and algorithm for sorting are
two orthogonal parameters that have sensible defaults: neither,
both or either can be independently specified. The resulting API
is slightly more verbose but also somewhat more self-documenting.

Another sign that this might be on the right track is that this
change reduces the LOC of base/sort.jl by 41 lines and reduces the
method count of sort, for example, from 12 to 6.
    @StefanKarpinski
    StefanKarpinski committed Jul 11, 2013
    Configuration menu
    Copy the full SHA
    73ecfd8 View commit details
    Browse the repository at this point in the history

  2. sorting: move matrix sorts up with other generic sorting functions.

    @StefanKarpinski
    StefanKarpinski committed Jul 11, 2013
    Configuration menu
    Copy the full SHA
    738c230 View commit details
    Browse the repository at this point in the history

  3. sorting: eliminate a few nans2{left,right} definitions via defaults.

    @StefanKarpinski
    StefanKarpinski committed Jul 11, 2013
    Configuration menu
    Copy the full SHA
    e5498d1 View commit details
    Browse the repository at this point in the history

  4. sorting: keyword arguments for by and lt as well.

    @StefanKarpinski
    StefanKarpinski committed Jul 11, 2013
    Configuration menu
    Copy the full SHA
    2409b35 View commit details
    Browse the repository at this point in the history

  5. sorting: make ReverseOrder parametric -- can reverse any ordering.

    @StefanKarpinski
    StefanKarpinski committed Jul 11, 2013
    Configuration menu
    Copy the full SHA
    3326e0c View commit details
    Browse the repository at this point in the history

  6. sorting: add rev boolean keyword to reverse any sort ordering. 

    Also added lt, by, order, rev keywords to the searchsorted* funcs.
    @StefanKarpinski
    StefanKarpinski committed Jul 11, 2013
    Configuration menu
    Copy the full SHA
    7bab350 View commit details
    Browse the repository at this point in the history

  7. sorting: deprecations for the old sorting API

    @StefanKarpinski
    StefanKarpinski committed Jul 11, 2013
    Configuration menu
    Copy the full SHA
    af97a6c View commit details
    Browse the repository at this point in the history