Fixed @test return value on Error (#31495)

[tisztamo]

This is directly mergeable and closes the bug #31495 by copying the two-liner proposed there by @tpapp , thus I do not feel comfortable prefixing RFC.

But this is also my first contribution as a boy scout and it would be great to get some feedback, especially because adding the missing tests was nontrivial and is not without issues:

• I was only able to create the missing tests for record(::DefaultTestSet, ::T <: Result) methods, but not for @test itself.
• Awkward output is printed, as seen here:

I think this is acceptable when a test system tests itself, but I would be happy to fix it. I just don't know how to start.

[tpapp]

Thanks for fixing this and providing a test, but I am not sure why you renamed the function arguments in unrelated code, it will make them inconsistent with the rest of the file.

[tisztamo]

Thanks for fixing this and providing a test, but I am not sure why you renamed the function arguments in unrelated code, it will make them inconsistent with the rest of the file.

I changed the names in methods of record() that I have found in this file, because they seemed to be inconsistent with the documentation:

https://github.com/JuliaLang/julia/blob/master/stdlib/Test/src/Test.jl#L669-L677

I failed to read other parts of the file, but now I see that t is used in quite a few places. As it always refers to a subtype of Result I still think that res would be a better name in every case, recovering file-level consistency. But I understand that this is subjective.

What do you think is the way to go? Should I rename them back to t, leave it as it is, change the documentation or change all occurrences of t to res?

[tpapp]

Generally I would suggest going for minimal changes in a PR like this.

[tisztamo]

Reverted the renaming. Can I do anything else to improve this PR?

[tpapp]

I think it is fine, you just have to wait for someone with commit rights to the repo to review it. Please give it some time, and ping here if it does not happen within a few days.

[tisztamo]

bump

[StefanKarpinski]

Thanks for the fix and the bump!