Fix and test LLVM IR for issue #36422 #36435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Jun 25, 2020
|
|
||
| @testset "#36422" begin | ||
| str_36422 = "using InteractiveUtils; code_llvm(Base.ht_keyindex, (Dict{NTuple{65,Int64},Nothing}, NTuple{65,Int64}))" | ||
| @test success(`$(Base.julia_cmd()) --startup-file=no -e $str_36422`) |
There was a problem hiding this comment.
Why is this in a new process? So it doesn't segfault the worker if it fails?
There was a problem hiding this comment.
We do have many tests that will just segfault the worker if they "fail", so I think it would be fine without the external process, but I don't care much either way.
There was a problem hiding this comment.
Yes, that's why. I saw this method used above, so I thought it would be desired. If I should change it I certainly can.
13 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jul 8, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36422 using @vtjnash's diff
Should get backported