Avoid potential buffer overflow/missing zero termination of string #36408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code path is only exercised when using |
staticfloat
approved these changes
Jun 24, 2020
martinholters
commented
Jun 25, 2020
staticfloat
approved these changes
Jun 25, 2020
staticfloat
force-pushed
the
mh/strncpy-fix
branch
from
dd8e0a3
to
a6b1144
Compare
Replace a `strncpy(dest, src, strlen(src))` with `strncpy(dest, src, DEST_SIZE); dest[DEST_SIZE-1]='\0'`. The old code could overflow the destination if the source was too long, defeating the purpose of `strncpy`. Further, it failed to put the terminating zero in the destination, relying on it being properly initialized.
This exercises the replacement of `DL_LOAD_PATH` entries that start with `@executable_path`.
...so that the test using the absolute path can be run unconditionally.
martinholters
force-pushed
the
mh/strncpy-fix
branch
from
a6b1144
to
388e186
Compare
|
I've moved the test using the absolute path first so that it can run unconditionally (it can, right?). If this passes tests, I think it should be ready to go. |
|
Thanks for helping out with the tests here, Elliot. Funny how they turned out to be much more involved than the fix itself... |
13 tasks
|
@staticfloat This seems to involve code that doesn't exist on 1.5 --- I don't see what can be backported? |
|
My bad; I thought it was in 1.5 but I guess I was wrong. :) |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
…uliaLang#36408) Co-authored-by: Elliot Saba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref 00abaf8#r39659418. Replace a
strncpy(dest, src, strlen(src))withstrncpy(dest, src, DEST_SIZE); dest[DEST_SIZE-1]='\0'. The old code could overflow the destination if the source was too long (not sure that could actually happen), defeating the purpose ofstrncpy. Further, it failed to put the terminating zero in the destination, relying on it being properly initialized.I have no idea about the context here, but this code path isn't exercised at all when I do
make test. Is that somehow system specific? Does CI cover this?