Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doctests for frexp, expm1, exponent #36352

Merged
merged 6 commits into from
Dec 9, 2020

Conversation

mgautam98
Copy link
Contributor

I added doctests for some of the maths functions

  1. frexp
  2. exponent
  3. expm1

base/math.jl Outdated Show resolved Hide resolved
@dkarrasch dkarrasch added the docs This change adds or pertains to documentation label Jun 22, 2020
show precision comparision with exp
Add full stop
base/math.jl Outdated Show resolved Hide resolved
@mgautam98
Copy link
Contributor Author

@simeonschaub I don't know why the tests are failing

@simeonschaub
Copy link
Member

The failure seems unrelated to this PR, so I wouldn't worry about it. That sometimes happens with the IO and threading tests.

@simeonschaub
Copy link
Member

@dkarrasch Could this be merged, once the merge conflicts are resolved?

@simeonschaub
Copy link
Member

@mgautam98 Can you rebase this to resolve the conflicts?

@ViralBShah
Copy link
Member

Let's merge if tests pass.

@dkarrasch
Copy link
Member

Test failures seem unrelated: time outs, internet connection, Distributed.

@dkarrasch dkarrasch merged commit ca3cd04 into JuliaLang:master Dec 9, 2020
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants