a few compiler improvements #36176
Merged
a few compiler improvements #36176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Jun 7, 2020
Keno
reviewed
Jun 7, 2020
66eea42
to
2521b73
Compare
|
Worth pointing out that we might not even need those generated functions if we fix #9080. |
- improve fieldtype_nothrow for vararg tuple types - remove UnionAll construction code from tuple_type_head - add specializations to avoid some common generated functions
2521b73
to
3d99561
Compare
Keno
reviewed
Jun 7, 2020
| return false | ||
| # If we don't know the exact type, the length of the tuple will be determined | ||
| # at runtime and we can't say anything. | ||
| return exact |
There was a problem hiding this comment.
This still doesn't seem right. fieldtype(NTuple{10, T} where T, 20) certainly does error.
There was a problem hiding this comment.
That doesn't contain a Vararg but I guess it might in the future, so I can add it.
There was a problem hiding this comment.
Fair enough. I guess we didn't change this yet.
Keno
reviewed
Jun 7, 2020
| @@ -776,6 +775,20 @@ end | |||
| end | |||
| end | |||
|
|
|||
| # Always index with the exactly indices provided. | |||
| @generated function _unsafe_getindex!(dest::AbstractArray, src::AbstractArray, I::Vararg{Union{Real, AbstractArray}, N}) where N | |||
| _generate_unsafe_getindex!_body(N) | |||
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
- improve fieldtype_nothrow for vararg tuple types - remove UnionAll construction code from tuple_type_head - add specializations to avoid some common generated functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shaves about 0.5 sec off the TTFP. The first two items fix some disastrous code for vararg tuple conversion: