Fix mkpath error handling #36126
Merged
Fix mkpath error handling #36126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error thrown by `mkdir` when the directory already exists was changed in #33422.
simonbyrne
commented
Jun 3, 2020
| @@ -228,7 +228,7 @@ function mkpath(path::AbstractString; mode::Integer = 0o777) | |||
| catch err | |||
| # If there is a problem with making the directory, but the directory | |||
| # does in fact exist, then ignore the error. Else re-throw it. | |||
| if !isa(err, SystemError) || !isdir(path) | |||
| if !isa(err, IOError) || !isdir(path) | |||
There was a problem hiding this comment.
Would it be better to do?
Suggested change
| if !isa(err, IOError) || !isdir(path) | |
| if !(isa(err, IOError) && err.code == UV_EEXIST) |
There was a problem hiding this comment.
I assume it doesn't matter because of the isdir test?
julia> mkpath("/nonexistant")
ERROR: IOError: mkdir: permission denied (EACCES)
Stacktrace:
[1] uv_error at ./libuv.jl:97 [inlined]
[2] mkdir(::String; mode::UInt16) at ./file.jl:177
[3] mkpath(::String; mode::UInt16) at ./file.jl:227
[4] mkpath(::String) at ./file.jl:222
[5] top-level scope at REPL[3]:1There was a problem hiding this comment.
Arguably in that case you would want the error to be propagated?
vtjnash
approved these changes
Jun 3, 2020
26 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jun 4, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
The error thrown by `mkdir` when the directory already exists was changed in JuliaLang#33422.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error thrown by
mkdirwhen the directory already exists was changed in #33422.Unfortunately, this is hard to test, though we came across it on a cluster with a shared file system.
cc: @jakebolewski @kpamnany