fix #36104, hack to allow accessing incomplete struct via dot syntax #36111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I merely commented this in person during review of #33553, but sometime soon in the roadmap, we're likely going to need to make it completely fine to access these incomplete structs via their global bindings at this stage of type construction (field type evaluation), per #32658. I think we could just do that part now (revert to evaluating these field types in normal / global scope), and defer adding some of the error checking from that PR later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't perfect, but hopefully it will be good enough to catch all practical cases. In 1.6 we should officially deprecate accessing an incomplete struct via its global binding.
fix #36104