fix #34516, several issues with nospecialize on keyword arguments #36019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `at-nospecialize(a)` syntax was not allowed as a kwarg - include nospecialize annotations in the keyword sorter method - we were dropping nospecialize applied to keyword arguments
JeffBezanson
added
kind:bugfix
|
Could something like this be used for #30411? |
timholy
added a commit
to JuliaDebug/JuliaInterpreter.jl
that referenced
this pull request
May 29, 2020
Back when we had more invalidations, some of these didn't help, but now they do. Moreover, JuliaLang/julia#36019 is already helping.
timholy
added a commit
to JuliaDebug/JuliaInterpreter.jl
that referenced
this pull request
May 29, 2020
Back when we had more invalidations, some of these didn't help, but now they do. Moreover, JuliaLang/julia#36019 is already helping.
timholy
added a commit
to JuliaDebug/JuliaInterpreter.jl
that referenced
this pull request
May 29, 2020
Back when we had more invalidations, some of these didn't help, but now they do. Moreover, JuliaLang/julia#36019 is already helping.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
…ments (JuliaLang#36019) - `at-nospecialize(a)` syntax was not allowed as a kwarg - include nospecialize annotations in the keyword sorter method - we were dropping nospecialize applied to keyword arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at-nospecialize(a)syntax was not allowed as a kwargfix #34516