Display argument that is duplicated in function calls

[ssikdar1]

Description

Fixes #34084

Now error message will also give the name of a variable duplicated in the function call.

Testing

julia> foo !== foo = bar
ERROR: syntax: function argument name not unique: foo around REPL[1]:1
Stacktrace:
 [1] top-level scope at REPL[1]:1

julia> function lala(;  bar=3, bar=4, boo=5)
       end
ERROR: syntax: function argument name not unique: bar around REPL[2]:1
Stacktrace:
 [1] top-level scope at REPL[2]:1

[ssikdar1]

Seems some doctests / tests need to be modified, I can do that if the change to error message is acceptable?

[JeffBezanson]

Need to fix the indenting here.

[ssikdar1]

Indentation fixed 5126389

[JeffBezanson]

I think we usually quote variable names in error messages, so how about Function argument name "x" not unique.

[ssikdar1]

I think we usually quote variable names in error messages, so how about Function argument name "x" not unique.
kk! Added in d10dfbb and unit test fixed in 7d17ada

[JeffBezanson]

Suggested change

	(anames (map (lambda (x) (if (underscore-symbol? x) UNUSED x))(llist-vars argl)))
	(anames (map (lambda (x) (if (underscore-symbol? x) UNUSED x)) (llist-vars argl)))

Plus the indentation is still wrong --- the start of each (var value) pair in the let* should line up. Any good code editor should have a scheme mode that does this automatically.

[ssikdar1]

Sorry, was using vi to edit the file. Used sublime editor to do the indentation automatically and added the space in suggestion in 02a087a

[JeffBezanson]

Thanks for taking the time to fix this up. Appreciated!