support random sampling of tuple types #35856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
This allows e.g `rand(NTuple{5,Int})` to sample a tuple of 5 `Int`s.
The implementation simply assembles a tuple by calling `rand` on the
corresponding type parameters of the tuple type.
A generated function is used to ensure type stability.
4c62bc0
to
9bd9afa
Compare
|
Rebased and added news entry. |
|
buildbot failures seem unrelated (network errors) |
|
I will have a closer look tentatively this week, but this won't make it for 1.6. In the meantime, the functionality can be found in RandomExtensions :) This means I personally definitely support this feature, but given that this package is not yet very popular, I suspect people are not dying for this functionality... |
rfourquet
added a commit
that referenced
this pull request
Oct 7, 2023
This is a rebase of #35856, where we keep only the tests, as the functionality was added in #50251. This also adds the possibility to call `rand` on an empty tuple type: `rand(Tuple{})`. Co-authored-by: Stephan Hilb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows e.g
rand(NTuple{5,Int})to sample a tuple of 5Ints.The implementation simply assembles a tuple by calling
randon thecorresponding type parameters of the tuple type.
A generated function is used to ensure type stability.
Note that this is distinct from
rand(::Tuple)to select a random element from a tuple.