Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cache logic for easy replacement #35831

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Refactor cache logic for easy replacement #35831

merged 4 commits into from
Jun 9, 2020

Commits on May 12, 2020

  1. Refactor cache logic for easy replacement

    This is the next step in the line of work started by #33955,
    though a lot of enabling work towards this was previously done
    by Jameson in his codegen-norecursion branch. The basic
    thrust here is to allow external packages to manage their own
    cache of compiled code that may have been generated using entirely
    difference inference or compiler options. The GPU compilers are one
    such example, but there are several others, including generating
    code using offload compilers, such as XLA or compilers for secure
    computation. A lot of this is just moving code arround to make it
    clear exactly which parts of the code are accessing the internal
    code cache (which is now its own type to make it obvious when
    it's being accessed), as well as providing clear extension points
    for custom cache implementations. The second part is to refactor
    CodeInstance construction to separate construction and insertion
    into the internal cache (so it can be inserted into an external
    cache instead if desired). The last part of the change
    is to give cgparams another hook that lets the caller replace
    the cache lookup to be used by codegen.
    Keno committed May 12, 2020
    Configuration menu
    Copy the full SHA
    c79044c View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Update base/compiler/cicache.jl

    Co-authored-by: Tim Besard <[email protected]>
    Keno and maleadt committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    770487f View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Apply suggestions from code review

    Co-authored-by: Jameson Nash <[email protected]>
    Keno and vtjnash committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    914d7f7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Configuration menu
    Copy the full SHA
    2df4e31 View commit details
    Browse the repository at this point in the history