Teach jl_load_dynamic_library() about @executable_path on all platforms
#35627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 30, 2020
staticfloat
force-pushed
the
sf/executable_path
branch
from
13d4e0b
to
d3b0c59
Compare
staticfloat
force-pushed
the
sf/executable_path
branch
from
28cdf1a
to
03c231b
Compare
vtjnash
approved these changes
May 4, 2020
staticfloat
force-pushed
the
sf/executable_path
branch
from
03c231b
to
599af83
Compare
|
I added a |
|
|
Needed in 1.5? |
|
Not needed; will merge after 1.5 branches. |
…tforms It is useful for us to be able to hard-code a dynamic library's location relative to that of the julia executable. We repurpose the `@executable_path` component from MacOS, allowing all platforms to perform executable-relative binary loading (I'm looking at you, Windows).
staticfloat
force-pushed
the
sf/executable_path
branch
from
599af83
to
00abaf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful for us to be able to hard-code a dynamic library's location
relative to that of the julia executable. We repurpose the
@executable_pathcomponent from MacOS, allowing all platforms toperform executable-relative binary loading (I'm looking at you, Windows).
This is useful for the Julia binary to be able to find libraries within artifacts in #35193