codegen: improve our argument annotations #35463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
The interesting thing about this is that these annotations should be correct and useful, but in fact they somehow block the vectorizer. This simulates what's happening in the performance regressions in #34126. |
Reflect that immutable struct parameters are readonly by the time LLVM can see them, even passed inside boxes. LLVM seems to require an explicit additional LICM call, to avoid regressions from this (observing the scheduling of fewer LICM calls).
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
This comment has been minimized.
This comment has been minimized.
|
Fun to see it improved |
|
The extra LICM pass doesn't seem to have much latency impact from what I can see so far, so let's go with this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect that immutable struct parameters are readonly by the time LLVM
can see them, even passed inside boxes.