Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrevert #34347 and bump Pkg to a version that is compatible with it #35390

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

KristofferC
Copy link
Sponsor Member

Fixes #34317

@DilumAluthge
Copy link
Member

Would be great to get a PkgEval on this, right?

@maleadt

@KristofferC
Copy link
Sponsor Member Author

Not really. Why? I tested that Pkg.test isn't broken here.

@maleadt
Copy link
Member

maleadt commented Apr 7, 2020

No need to run all the tests though, as this broke all packages:
@nanosoldier runtests(["Example"], vs = ":master")

@JeffBezanson
Copy link
Sponsor Member

We could make this more backwards compatible by keeping have_color as a boolean with roughly the meaning it had before, and using a new name for the 3-valued variable we use internally.

@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(["Example"], vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - no new issues were detected. A full report can be found here. cc @maleadt

@KristofferC
Copy link
Sponsor Member Author

We could make this more backwards compatible by keeping have_color as a boolean with roughly the meaning it had before, and using a new name for the 3-valued variable we use internally.

Let's get his back in since quite a lot of time was spent on reviewing and fixing up the original PR and then we can add the extra backwards compat later if we think it is needed (perhaps from a full PkgEval at some point).

@KristofferC KristofferC merged commit 4efb718 into master Apr 8, 2020
@KristofferC KristofferC deleted the kc/revrev branch April 8, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable color output whenever stdout is a TTY
5 participants