Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump utf8proc version, support Unicode 13 #35282

Merged
merged 2 commits into from
Mar 30, 2020
Merged

bump utf8proc version, support Unicode 13 #35282

merged 2 commits into from
Mar 30, 2020

Conversation

stevengj
Copy link
Member

Updates to utf8proc 2.5.0, which supports Unicode 13.0.0.

(Also updates the Unicode data files used for generating the documentation, which is not strictly necessary but may reduce confusion. Closes #33965. Closes #33967.)

@stevengj stevengj added the domain:unicode Related to unicode characters and encodings label Mar 28, 2020
@ararslan
Copy link
Member

I think this will also need a bump to the version used with USE_BINARYBUILDER=1, unless we aren't currently serving utf8proc from BinaryBuilder.

@stevengj
Copy link
Member Author

stevengj commented Mar 29, 2020 •
edited
Loading

@ararslan, how do I do that?

(utf8proc isn't listed in the BB_PROJECTS variable in the Makefile. But I'm not quite sure how this is hooked into the dependency builds.)

@stevengj stevengj mentioned this pull request Mar 29, 2020
Merged
@ararslan
Copy link
Member

Tbh I'm not entirely sure either. Looks like you got the Yggdrasil piece though. @staticfloat, can you provide some sagely guidance here?

@stevengj
Copy link
Member Author

Okay, I've dug a bit further. utf8proc is currently not using binarybuilder at all in Julia, so this PR should be good to merge as-is.

(Since Yggdrasil is building utf8proc now, we could add binarybuilder support, but that could be done in a separate PR.)

@ararslan
Copy link
Member

A news entry saying that the version was updated may be worthwhile but also ¯\_(ツ)_/¯

StefanKarpinski
StefanKarpinski approved these changes Mar 30, 2020
View reviewed changes
Copy link
Sponsor Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge once CI passes.

@ararslan ararslan merged commit b6c06dd into master Mar 30, 2020
@ararslan ararslan deleted the unicode13 branch March 30, 2020 16:33
oxinabox pushed a commit to oxinabox/julia that referenced this pull request Apr 8, 2020
@stevengj @oxinabox
bump utf8proc version, support Unicode 13 (JuliaLang#35282)
d0965c7
ravibitsgoa pushed a commit to ravibitsgoa/julia that referenced this pull request Apr 9, 2020
@stevengj @ravibitsgoa
bump utf8proc version, support Unicode 13 (JuliaLang#35282)
ca3006d
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@stevengj @KristofferC
bump utf8proc version, support Unicode 13 (#35282)
c61f916
staticfloat pushed a commit that referenced this pull request Apr 21, 2020
@stevengj @staticfloat
bump utf8proc version, support Unicode 13 (#35282)
a202b23
@Seelengrab Seelengrab mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
domain:unicode Related to unicode characters and encodings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unicode reference version
3 participants
@stevengj @ararslan @StefanKarpinski