Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch list for LLVM 10 #35270

Merged
merged 2 commits into from
Mar 29, 2020
Merged

add patch list for LLVM 10 #35270

merged 2 commits into from
Mar 29, 2020

Conversation

vchuravy
Copy link
Sponsor Member

I have an outdated PR for Yggdrasil as well JuliaPackaging/Yggdrasil#456

@vchuravy vchuravy requested a review from vtjnash March 27, 2020 02:02
@vchuravy
Copy link
Sponsor Member Author

Fails right now with:

In file included from /data/vchuravy/builds/julia-10/usr/include/llvm/ExecutionEngine/Orc/CompileUtils.h:16:0,                                     
                 from /data/vchuravy/src/julia/src/jitlayers.h:10,                                                                                 
                 from /data/vchuravy/src/julia/src/jitlayers.cpp:27:                                                                               
/data/vchuravy/builds/julia-10/usr/include/llvm/ExecutionEngine/Orc/IRCompileLayer.h: In instantiation of ‘llvm::Error llvm::orc::LegacyIRCompileLayer<BaseLayerT, CompileFtor>::addModule(llvm::orc::VModuleKey, std::unique_ptr<llvm::Module>) [with BaseLayerT = llvm::orc::LegacyRTDyldObjectLink$ngLayer; CompileFtor = JuliaOJIT::CompilerT; llvm::orc::VModuleKey = long unsigned int]’:
/data/vchuravy/src/julia/src/jitlayers.cpp:537:54:   required from here
/data/vchuravy/builds/julia-10/usr/include/llvm/ExecutionEngine/Orc/IRCompileLayer.h:111:18: error: ‘class std::unique_ptr<llvm::MemoryBuffer>’ ha$ no member named ‘takeError’
       return Obj.takeError();
              ~~~~^~~~~~~~~
/data/vchuravy/builds/julia-10/usr/include/llvm/ExecutionEngine/Orc/IRCompileLayer.h:112:14: error: no matching function for call to ‘llvm::orc::L$gacyRTDyldObjectLinkingLayer::addObject(std::remove_reference<long unsigned int&>::type, std::remove_reference<llvm::MemoryBuffer&>::type)’
     if (auto Err = BaseLayer.addObject(std::move(K), std::move(*Obj)))
              ^~~
In file included from /data/vchuravy/src/julia/src/jitlayers.h:14:0,
                 from /data/vchuravy/src/julia/src/jitlayers.cpp:27:
/data/vchuravy/builds/julia-10/usr/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h:391:9: note: candidate: llvm::Error llvm::orc::Lega$yRTDyldObjectLinkingLayer::addObject(llvm::orc::VModuleKey, llvm::orc::LegacyRTDyldObjectLinkingLayerBase::ObjectPtr)
   Error addObject(VModuleKey K, ObjectPtr ObjBuffer) {
         ^~~~~~~~~
/data/vchuravy/builds/julia-10/usr/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h:391:9: note:   no known conversion for argument 2 f$om ‘std::remove_reference<llvm::MemoryBuffer&>::type {aka llvm::MemoryBuffer}’ to ‘llvm::orc::LegacyRTDyldObjectLinkingLayerBase::ObjectPtr {aka s$d::unique_ptr<llvm::MemoryBuffer>}’

@vchuravy vchuravy merged commit ac22a6d into master Mar 29, 2020
@vchuravy vchuravy deleted the vc/llvm10 branch March 29, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant