Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add informative error message for map!(f, array) #35186

Merged
merged 1 commit into from
Mar 31, 2020
Merged

add informative error message for map!(f, array) #35186

merged 1 commit into from
Mar 31, 2020

Conversation

rfourquet
Copy link
Member

For example:

julia>  map!(-, [1]) # master
ERROR: BoundsError: attempt to access ()
  at index [1]
Stacktrace:
[...]

julia>  map!(-, [1]) # PR
ERROR: ArgumentError: map! requires at least one "source" argument
Stacktrace:
[...]

@rfourquet
add informative error message for map!(f, array)
83c007d 
For example:
```julia
julia>  map!(-, [1]) # master
ERROR: BoundsError: attempt to access ()
  at index [1]
Stacktrace:
[...]

julia>  map!(-, [1]) # PR
ERROR: ArgumentError: map! requires at least one "source" argument
Stacktrace:
[...]
```
@rfourquet rfourquet added error handling Handling of exceptions by Julia or the user collections Data structures holding multiple items, e.g. sets labels Mar 20, 2020
@dkarrasch dkarrasch merged commit afb9ad4 into master Mar 31, 2020
@dkarrasch dkarrasch deleted the rf/warn-map-bang-1arg branch March 31, 2020 07:59
oxinabox pushed a commit to oxinabox/julia that referenced this pull request Apr 8, 2020
@rfourquet @oxinabox
add informative error message for map!(f, array) (JuliaLang#35186)
5320912
ravibitsgoa pushed a commit to ravibitsgoa/julia that referenced this pull request Apr 9, 2020
@rfourquet @ravibitsgoa
add informative error message for map!(f, array) (JuliaLang#35186)
b687282
staticfloat pushed a commit that referenced this pull request Apr 21, 2020
@rfourquet @staticfloat
add informative error message for map!(f, array) (#35186)
4368cd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
collections Data structures holding multiple items, e.g. sets error handling Handling of exceptions by Julia or the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfourquet @StefanKarpinski @dkarrasch