Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow packages to provide custom hints for Exceptions #35094

Merged
merged 8 commits into from
Mar 20, 2020
Merged

Allow packages to provide custom hints for Exceptions #35094

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0771bd4
Allow packages to provide custom hints for MethodErrors
timholy Mar 12, 2020
1cb46c9
Add NEWS and compat info
timholy Mar 13, 2020
d269fd3
Mention push from __init__
timholy Mar 13, 2020
e9a3c40
Quote demo with backticks rather than indentation
timholy Mar 14, 2020
70d8679
Generalize the hint mechanism
timholy Mar 14, 2020
20e2afe
Don't test for color in demo
timholy Mar 14, 2020
fa5e924
Add a test for busted error-hint handlers
timholy Mar 14, 2020
b775889
Eliminate the doctests and fix docs
timholy Mar 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't test for color in demo
  • Loading branch information
@timholy
timholy committed Mar 14, 2020
commit 20e2afe2fd40b0b56b036d034a0cd50102742895
8 changes: 2 additions & 6 deletions base/errorshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,8 @@ julia> module Hinter
function __init__()
register_error_hint(MethodError) do io, exc, argtypes, kwargs
if exc.f == only_int
if get(io, :color, false)
print(io, "\nDid you mean to call ")
printstyled(io, "`any_number`?", color=:light_magenta)
else
print(io, "\nDid you mean to call `any_number`?")
end
print(io, "\nDid you mean to call ")
printstyled(io, "`any_number`?", color=:light_magenta)
end
end
end
Expand Down