Bump OpenBLAS yet again #35041
Merged
Bump OpenBLAS yet again #35041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The number of files these things touch is a bit insane! |
|
yeah, each checksum is a separate file because that's easy to check in a shell script, but we should probably do something more intelligent here, like have a tab-separated file like Shouldn't be too bad to handle with standard unix tools. |
|
wouldn't standard unix tools break on windows? |
|
No, our build system already depends on them, so we assume their presence on windows (either through cygwin or msys). |
|
Is there a reason to not go to the latest version (now 0.3.9)? Possibly this change was in the pipeline for a long time. I however see e.g. in latest version:
and
|
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous patch I had was incomplete.