dump: remove dependency on uid field [NFCI] #34980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
reviewed
Mar 3, 2020
| // if (!type_parameter_recursively_external(((jl_unionall_t*)p)->var->ub)) | ||
| // return 0; | ||
| // p = (jl_datatype_t*)((jl_unionall_t*)p)->body; | ||
| //} |
There was a problem hiding this comment.
It seemed probably good, but wasn't really functional anymore, and we're not to the point yet where this is a performance bottleneck.
JeffBezanson
approved these changes
Mar 3, 2020
Addresses part of #34890
348cf53
to
c10206d
Compare
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
Addresses part of JuliaLang#34890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
uid != 0withisconcretetypeand theO(n^2)iteration in jl_recache_types with a hash table. Addresses part of #34890