codegen: fix segfaults with VecElement with union element #34805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were being too aggressive at unwrapping these: since they are already unwrapped once, they need to be treated almost as a normal struct. fixes #29864
KristofferC
pushed a commit
that referenced
this pull request
Feb 19, 2020
26 tasks
birm
pushed a commit
to birm/julia
that referenced
this pull request
Feb 22, 2020
…34805) We were being too aggressive at unwrapping these: since they are already unwrapped once, they need to be treated almost as a normal struct. fixes JuliaLang#29864
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
We were being too aggressive at unwrapping these: since they are already unwrapped once, they need to be treated almost as a normal struct. fixes #29864
BioTurboNick
pushed a commit
to BioTurboNick/julia
that referenced
this pull request
Apr 13, 2020
…34805) We were being too aggressive at unwrapping these: since they are already unwrapped once, they need to be treated almost as a normal struct. fixes JuliaLang#29864 (cherry picked from commit 8720530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were being too aggressive at unwrapping these: since they are already
unwrapped once, they need to be treated almost as a normal struct.
fixes #29864