Add AddrSpacePtr type #34760
Merged
Add AddrSpacePtr type #34760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vchuravy
reviewed
Feb 14, 2020
vchuravy
approved these changes
Feb 21, 2020
12d8b70
to
2b83127
Compare
|
@vchuravy Done |
2b83127
to
8cb8f0c
Compare
|
Did another rebase so CI passes now. |
bors bot
added a commit
to JuliaGPU/CUDAnative.jl
that referenced
this pull request
Feb 23, 2020
557: Use AddrSpacePtr to call WMMA intrinsics r=vchuravy a=thomasfaingnaert Closes #548 Depends on JuliaLang/julia#34760 Co-authored-by: Thomas Faingnaert <[email protected]>
bors bot
added a commit
to JuliaGPU/CUDAnative.jl
that referenced
this pull request
Feb 24, 2020
557: Use AddrSpacePtr to call WMMA intrinsics r=thomasfaingnaert a=thomasfaingnaert Closes #548 Depends on JuliaLang/julia#34760 Co-authored-by: Thomas Faingnaert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some intrinsics of the LLVM NVPTX backend have argument types
i8 addrspace(x)*.At the moment, there is no way to
ccallthese intrinsics, sinceRef{T}is converted to the plaini8*.As discussed in JuliaGPU/CUDAnative.jl#548, this PR adds an
ASPtr{T, AS}type whose sole purpose is to ensure that codegen emits an LLVMi8 addrspace(x)*when usingccall(..., llvmcall, ...).// cc: @vchuravy, @maleadt