fix _spawn_primitive to report error correctly #34716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method `_spawn_primitive` in `process.jl` seems to be defining a local valiable that shadows the `error` method that it tries to use.
This renames the local variable to fix that.
Below are a few lines to simulate the condition.
Before:
```
julia> Base.rawhandle(s::String) = s
julia> Base._spawn_primitive("/tmp/xyx", `ls`, Any["abc"])
ERROR: UndefVarError: error not defined
Stacktrace:
[1] _spawn_primitive(::String, ::Cmd, ::Array{Any,1}) at ./process.jl:79
[2] top-level scope at REPL[2]:1
```
With this fix:
```
julia> Base.rawhandle(s::String) = s
julia> Base._spawn_primitive("/tmp/xyx", `ls`, Any["abc"])
ERROR: invalid spawn handle abc from abc
Stacktrace:
[1] error(::String) at ./error.jl:33
[2] _spawn_primitive(::String, ::Cmd, ::Array{Any,1}) at ./process.jl:79
[3] top-level scope at REPL[4]:1
```
|
Win32 test seem to have timed out (also it looks like all test cases in that did pass). |
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Method `_spawn_primitive` in `process.jl` seems to be defining a local valiable that shadows the `error` method that it tries to use. This renames the local variable to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
_spawn_primitiveinprocess.jlseems to be defining a local valiable that shadows theerrormethod that it tries to use.This renames the local variable to fix that.
Below are a few lines to simulate the condition.
Before:
With this fix: