parser error for invalid : after imports
#34694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
reviewed
Feb 7, 2020
JeffBezanson
reviewed
Feb 7, 2020
JeffBezanson
reviewed
Feb 7, 2020
dd232d1
to
d69df30
Compare
d69df30
to
8d65c22
Compare
|
Just a friendly bump. Should be ready to merge now. |
|
@JeffBezanson Have you had time to take another look at this? |
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't quite sure, whether this should throw during parsing or lowering. I chose to have it throw during parsing, because I can't really see a situation, where the current parsing of expressions like
using A, B: xas(:)((using A, B;), x)would be useful and we might eventually want to support this syntax and make this behave like users would expect it to.Fix #34650