soft scope: fix doc tests #34566
Merged
soft scope: fix doc tests #34566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@staticfloat, any idea why the doctest buildbot isn't running? I believe it needs to run in order to deploy the fixed docs. |
|
I'm not totally sure why yet, but the buildbots seem to be really swamped today. It's taking a while for a runner to catch up to the queue and report status back to GitHub. |
mortenpi
added a commit
to mortenpi/julia
that referenced
this pull request
Jan 30, 2020
This reverts commit 1ac04ad.
KristofferC
pushed a commit
that referenced
this pull request
Feb 3, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original PR, these were hidden by the fact that a stray leading space caused what was considered code and not to be messed up for the second half of this file. Then the PR that fixed it didn't have CI run (not sure why). This fixes the doc tests but ideally should be reverted once Documenter supports the new soft scope behavior correctly.