Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in #34465 #34476

Merged
merged 2 commits into from
Jan 22, 2020
Merged

fix typo in #34465 #34476

merged 2 commits into from
Jan 22, 2020

Conversation

tpapp
Copy link
Contributor

@tpapp tpapp commented Jan 22, 2020

#34465 introduced a typo, this now fixes it. thanks @dkarrasch

@@ -32,7 +32,7 @@ New library functions
* The new `only(x)` function returns the one-and-only element of a collection `x`, and throws an `ArgumentError` if `x` contains zero or multiple elements ([#33129]).
* `takewhile` and `dropwhile` have been added to the Iterators submodule ([#33437]).
* `accumulate` has been added to the Iterators submodule ([#34033]).
* There is a now an `evalpoly` function meant to take the role of the `@evalpoly` macro. The function is just as efficient as the macro while giving added flexibility, so it should be preferred over `@evalpoly`. `evalpoly` takes a list of coefficients as a tuple, so where one might write `@evalpoly(x, p1, p2, p3)` one would instead write `evalpoly(x, (p1, p2, p3))` (#[32753]).
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual link needs to be added to the bottom of the file, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/JuliaLang/julia/blob/master/CONTRIBUTING.md#news-worthy-changes, it does not need to be done in the PR, but I ran the script anyway and made a commit anyway as I am assuming we are nearing an RC.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is making the PR towards the release branch which is why I thought it makes sense to do it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree, so now it is done.

Sorry for the mistakes and the noise. I hope it can be merged now without me ending up in the Most Bugs in a PR per Characters Changed Hall of Fame.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, you'll never top 04e1c98.

@rfourquet rfourquet merged commit 8852200 into JuliaLang:release-1.4 Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants