Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blas hpmv minor updates #34439

Merged
merged 4 commits into from
Feb 20, 2020
Merged

Blas hpmv minor updates #34439

merged 4 commits into from
Feb 20, 2020

Conversation

iolaszlo
Copy link
Contributor

iolaszlo added a commit to iolaszlo/julia that referenced this pull request Jan 19, 2020
@iolaszlo
Minor updates to BLAS/hpmv! as in JuliaLang#34320. [JuliaLang#34439]
cb11ac7 
Follow the syntax, docstring and testing conventions
elaborated in JuliaLang#34320.
@iolaszlo iolaszlo force-pushed the blas-hpmv-minor-updates branch 2 times, most recently from cb11ac7 to 45b2eec Compare January 19, 2020 20:05
iolaszlo added a commit to iolaszlo/julia that referenced this pull request Jan 19, 2020
@iolaszlo
Minor updates to BLAS/hpmv! as in JuliaLang#34320. [JuliaLang#34439]
45b2eec 
Follow the syntax, docstring and testing conventions
elaborated in JuliaLang#34320.
@dkarrasch dkarrasch added the domain:linear algebra Linear algebra label Jan 20, 2020
@dkarrasch
Copy link
Member

Once #34783 is merged, this will need a rebase.

@iolaszlo
Minor updates to BLAS/hpmv! as in JuliaLang#34320. [JuliaLang#34439]
bee1d09 
Follow the syntax, docstring and testing conventions
elaborated in JuliaLang#34320.
dkarrasch
dkarrasch approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The GC.@preserve change is already included in #34783, so once that is merged and this is rebased, the change in that line is going to disappear from the change log.

@dkarrasch dkarrasch merged commit 6a9a926 into JuliaLang:master Feb 20, 2020
birm pushed a commit to birm/julia that referenced this pull request Feb 22, 2020
@iolaszlo @birm
Blas hpmv minor updates (JuliaLang#34439)
1dfdad3
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@iolaszlo @KristofferC
Blas hpmv minor updates (#34439)
71448e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees
No one assigned
Labels
domain:linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iolaszlo @dkarrasch