Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct version for master docs #34260

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Conversation

mortenpi
Copy link
Contributor

@mortenpi mortenpi commented Jan 5, 2020

Ideally, it should have been updated in #34218. Fix #34259.

cc @fredrikekre

Ideally, it should have been updated in JuliaLang#34218. Fix JuliaLang#34259.
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jan 5, 2020

Can you add this to the release checklist also in the toplevel Makefile?

@ViralBShah ViralBShah added domain:docs This change adds or pertains to documentation docsystem The documentation building system and removed domain:docs This change adds or pertains to documentation labels Jan 5, 2020
@mortenpi
Copy link
Contributor Author

mortenpi commented Jan 6, 2020

I'd say that this is good to go.

Also, just for the record, this could probably be automated by taking these values from the VERSION file. But I'd leave that as up for grabs for someone else at the moment.

@KristofferC KristofferC merged commit 8e6a2ae into JuliaLang:master Jan 7, 2020
fredrikekre added a commit that referenced this pull request Jan 7, 2020
fredrikekre added a commit that referenced this pull request Jan 8, 2020
* Revert "Use correct version for master docs (#34260)"

This reverts commit 8e6a2ae.

* Define in-development docs URL programmatically.
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
* Use correct version for master docs

Ideally, it should have been updated in #34218. Fix #34259.

* Update release checklist
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
* Revert "Use correct version for master docs (#34260)"

This reverts commit 8e6a2ae.

* Define in-development docs URL programmatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsystem The documentation building system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation issue: 1.4-dev page showing 1.5 version
4 participants