Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete! for WeakKeyDict. #34203

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Fix delete! for WeakKeyDict. #34203

merged 2 commits into from
Dec 30, 2019

Conversation

twavv
Copy link
Contributor

@twavv twavv commented Dec 27, 2019

Relatively minor thing. Currently, delete! for WeakKeyDicts returns the underlying dict implementation rather than the WeakKeyDict like it's supposed to.

# Julia 1.3
julia> wkd = WeakKeyDict()
WeakKeyDict{Any,Any} with 0 entries

julia> delete!(wkd, "foo")
Dict{WeakRef,Any} with 0 entries

JeffBezanson
JeffBezanson reviewed Dec 27, 2019
View reviewed changes
base/weakkeydict.jl Outdated Show resolved Hide resolved
@JeffBezanson
Copy link
Sponsor Member

Good catch!

@JeffBezanson JeffBezanson added the kind:bugfix This change fixes an existing bug label Dec 27, 2019
@twavv
Copy link
Contributor Author

twavv commented Dec 28, 2019

Fixed typo 🙃

@KristofferC KristofferC added the needs news A NEWS entry is required for this change label Dec 28, 2019
@twavv
Copy link
Contributor Author

twavv commented Dec 29, 2019

Happy to add to NEWS.md, but not sure where this would fit in.

@KristofferC
Copy link
Sponsor Member

Language changes maybe?

@JeffBezanson
Copy link
Sponsor Member

Standard library changes.

@JeffBezanson JeffBezanson merged commit e03b730 into JuliaLang:master Dec 30, 2019
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@twavv @KristofferC
Fix delete! for WeakKeyDict to return the right object (#34203)
6e575c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson left review comments

Assignees
No one assigned
Labels
kind:bugfix This change fixes an existing bug needs news A NEWS entry is required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twavv @JeffBezanson @KristofferC